Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BaseActiveRecord #314

Merged
merged 4 commits into from
May 19, 2024
Merged

Refactor BaseActiveRecord #314

merged 4 commits into from
May 19, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented May 19, 2024

Q A
Is bugfix? ✔️/❌
New feature?
Breaks BC?
Fixed issues #308

Copy link

codecov bot commented May 19, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.25%. Comparing base (090db08) to head (6e8f4af).

Files Patch % Lines
src/BaseActiveRecord.php 92.59% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
- Coverage     88.63%   88.25%   -0.38%     
+ Complexity      575      566       -9     
============================================
  Files             8        8              
  Lines          1302     1294       -8     
============================================
- Hits           1154     1142      -12     
- Misses          148      152       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov merged commit 441a887 into master May 19, 2024
56 of 57 checks passed
@Tigrov Tigrov deleted the refactor-BaseActiveRecord branch May 19, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants