-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration: liquity #134
base: dev
Are you sure you want to change the base?
integration: liquity #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments, let me know if you need any more info.
knowledge_base/widgets.txt
Outdated
If the user is trying to borrow more LUSD and/or deposit more collateral | ||
-{borrowAmount}: amount of LUSD to borrow | ||
-{collateralAmount}: amount of ETH to use as collateral |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seems to be a mismatch of the parameters here and in the command above. also, if there are 2 use cases, what should the variables be when not being used (e.g. what to put for repay/withdraw if doing borrow/deposit)? could we just have 2 magic commands for 2 different use cases?
Note that we now have a knowledge_base/functions.json that needs to be kept in sync with widgets.txt changes, otherwise the ChatGPT functions chat will not have these. Main tracking issue to remove this coupling here #128 |
With #150, widgets.txt and functions.json have been merged into one widgets.yaml that needs to be updated. So updates to this diff should be done to widgets.yaml instead. To avoid conflicts during merge, it might be preferable to start a fresh PR from the latest dev branch (unless you plan to restore the original widgets.txt and squash/force push the branch with it). |
Description
Corresponds to our liquity borrow/close/adjust/repay frontend integration.