Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum harness config #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Arbitrum harness config #12

wants to merge 2 commits into from

Conversation

iamsahu
Copy link
Contributor

@iamsahu iamsahu commented Mar 20, 2023

No description provided.

Sabnock01
Sabnock01 approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Sabnock01 Sabnock01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice. Had it been me, I'd have tried to fit the Arbitrum config into the main harness file, but I like this approach better of having a separate file per chainId.

@Sabnock01
Copy link
Contributor

Actually. Maybe we can create files with only the config values and then import them into the main harness file? That way there's less repetition. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sabnock01 Sabnock01 Sabnock01 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iamsahu @Sabnock01