Implemented PL #30
Closed
Implemented PL #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, now I realised I made a pull request with two additional files (which shouldn't be part of this PR), closing this now and opening a new PR later. |
|
Thank you for the submissions. Sorry, I had not had time to review the main parts, but I look forward to future contributions. Are you okay with releasing under MIT License? Do your changes handle saving the PL label as well? |
|
Yes, MIT license is OK. I didn't check saving (viewing was most important for me), but I'll take a look, thanks for the reminder! And one more thing I'd probably like to add is a button to switch player when editing the SGF. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented PL (next player color).
Fixes #29