This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
options.copy work with tests #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@eddiemonge anything else I can do to get this merged? |
|
looks good to me. @sindresorhus want to add a second opinion? If not, I'll merge it in. |
|
@eddiemonge @sindresorhus any news, or suggestions? |
|
Can you squash your commits down? |
Closed
If you specify multiple file specs and the first one sets move to false, it affects all subsequent ones even if you want them to have move = true.
added copy option to README added tests to cover scenarios where the copy option isn't set
before: Fatal error: Destination for target %s is not a directory now: Fatal error: Destination build/js/app.min.js for target jadeUsemin-js is not a directory
|
oh, i made a hash out of that, didn't i :-) I'll come back later to this. |
|
I've re-forked the current repo and am going to open a new PR. Apologies for the mess. |
|
Closing this PR in favour of #38, which has the same changes (plus one tidy-up), but in a single commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small update to #21. They were previously committed to @ProLoser's fork, but he isn't maintaining it any more.