feat: new yearn landing (#571) #608

w84april · 2024-11-20T09:37:23Z

feat: wip sidebar
fix: build fix
feat: search & category sections & style changes
feat: carousel & search icon & hovers
feat: cutaways + scrollbar dismiss + search layout + mobile layout
feat: arrows for scroll + small fixes
feat: imp of useSearch + small changes
fix: small fix
feat: filterBar + sorting
fix: small fix
fix: style changes
fix: mobile style fixes
feat: first round of apps
fix: type
fix: menu
entrance anim
feat: styles updates
fix: small change
fix: mobile add card imp
feat: add description to apps
feat: add icons
feat: wip sidebar
fix: build fix
feat: search & category sections & style changes
feat: carousel & search icon & hovers
feat: cutaways + scrollbar dismiss + search layout + mobile layout
feat: arrows for scroll + small fixes
feat: imp of useSearch + small changes
fix: small fix
feat: filterBar + sorting
fix: small fix
fix: style changes
fix: mobile style fixes
feat: first round of apps
fix: type
fix: menu
entrance anim
feat: styles updates
fix: small change
fix: mobile add card imp
feat: add description to apps
feat: add icons
fix: featured apps
fix: upd images
feat: changed sizes + hovers
feat: small changes
fix: assets
fix: some spacing
fix: design change
chore: remove featured app label
feat: randomize integration apps
feat: moved About to the end of menu
feat: shuffle all apps
feat: carousel with controls
chore: ts fix
chore: route fix
feat: change some descriptin and catrgory name
chore: type fix
fix: animation with search
feat: upd copy
feat: redirect
fix: animation bug
feat: mobile fixes
fix: img

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

* feat: wip sidebar * fix: build fix * feat: search & category sections & style changes * feat: carousel & search icon & hovers * feat: cutaways + scrollbar dismiss + search layout + mobile layout * feat: arrows for scroll + small fixes * feat: imp of useSearch + small changes * fix: small fix * feat: filterBar + sorting * fix: small fix * fix: style changes * fix: mobile style fixes * feat: first round of apps * fix: type * fix: menu * entrance anim * feat: styles updates * fix: small change * fix: mobile add card imp * feat: add description to apps * feat: add icons * feat: wip sidebar * fix: build fix * feat: search & category sections & style changes * feat: carousel & search icon & hovers * feat: cutaways + scrollbar dismiss + search layout + mobile layout * feat: arrows for scroll + small fixes * feat: imp of useSearch + small changes * fix: small fix * feat: filterBar + sorting * fix: small fix * fix: style changes * fix: mobile style fixes * feat: first round of apps * fix: type * fix: menu * entrance anim * feat: styles updates * fix: small change * fix: mobile add card imp * feat: add description to apps * feat: add icons * fix: featured apps * fix: upd images * feat: changed sizes + hovers * feat: small changes * fix: assets * fix: some spacing * fix: design change * chore: remove featured app label * feat: randomize integration apps * feat: moved About to the end of menu * feat: shuffle all apps * feat: carousel with controls * chore: ts fix * chore: route fix * feat: change some descriptin and catrgory name * chore: type fix * fix: animation with search * feat: upd copy * feat: redirect * fix: animation bug * feat: mobile fixes * fix: img --------- Co-authored-by: Majorfi <[email protected]> Co-authored-by: Major <[email protected]> Co-authored-by: Daniil Polienko <[email protected]>

vercel · 2024-11-20T09:37:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yearnfi	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 20, 2024 2:25pm

* feat: migrate landing * feat: add about & partners sections * feat: add contribute, form & footer * fix: partners * fix: bgs * feat: hero animation (#607) * fix: mobile * update: mobile layout * update: og * fix: header * fix: minor stuff * fix: mobile menu * fix: mobile colors * fix: mobile styles * fix: icons * fix: merge * fix: import * chore: import order * updage: links * fix: links --------- Co-authored-by: Karlen9 <[email protected]> Co-authored-by: Karlen9 <[email protected]>

Majorfi · 2024-11-20T12:50:20Z

tailwind.config.js

+					500: '#424242',
+					600: '#292929',
+					700: '#282828',
+					800: '#181818',


@w84april could you fix this before release?

Majorfi · 2024-11-20T12:53:52Z

apps/landing/components/sections/About.tsx

+						{
+							'Unlike a bank account - none of this takes place behind closed doors (no offence to doors). DeFi'
+						}
+						{
+							'runs on public blockchains, so you are in control of your assets and can see where they are at all'
+						}
+						{'times.'}


Why 3 differents stuff here?

So that the line was not bigger than allowed by linter i think

Let's just put everything in line, linter should not complain about that for single string

{'Unlike a bank account - none of this takes place behind closed doors (no offence to doors). DeFi runs on public blockchains, so you are in control of your assets and can see where they are at all times.'}

Majorfi · 2024-11-20T12:54:03Z

apps/landing/components/sections/About.tsx

+							{'your assets, andYearn puts them to work within the DeFi ecosystem, returning the earned'}
+							{'yield back to you.'}


Why 2 differents stuff here?

Majorfi · 2024-11-20T12:54:23Z

apps/landing/components/sections/About.tsx

+						{
+							'In ‘traditional finance’ (boo, hiss) you can earn yield on your savings by depositing them in a bank'
+						}
+						{'- who use the capital for loans and other productive money growing means.'}


Why 2 differents stuff here?

Majorfi · 2024-11-20T12:54:43Z

apps/landing/components/sections/About.tsx

+				{!isReadMore && (
+					<button
+						className={'mt-6 text-lg font-light text-primary'}
+						onClick={() => set_isReadMore(true)}>
+						{'Read more'}
+					</button>
+				)}


Suggested change

{!isReadMore && (

<button

className={'mt-6 text-lg font-light text-primary'}

onClick={() => set_isReadMore(true)}>

{'Read more'}

</button>

)}

{!isReadMore ? (

<button

className={'mt-6 text-lg font-light text-primary'}

onClick={() => set_isReadMore(true)}>

{'Read more'}

</button>

) : null}

Let's avoid && for conditional render

Majorfi · 2024-11-20T13:00:17Z

apps/common/components/MobileNavbar.tsx

+					</Link>
+					<Link
+						target={'_blank'}
+						href={''}>


Missing link

Majorfi · 2024-11-20T13:02:01Z

apps/common/components/SortingBar.tsx

+			{isOpen && (
+				<div
+					className={
+						'border-1 absolute top-28 z-30 w-80 border border-gray-700 bg-gray-500 py-2 text-white max-sm:left-0 md:right-1 md:top-10'
+					}>
+					{Array(4)
+						.fill('List Item')
+						.map((item, i) => (
+							<SortItem
+								isActive={i === 2}
+								title={item}
+							/>
+						))}
+				</div>
+			)}


Suggested change

{isOpen && (

<div

className={

'border-1 absolute top-28 z-30 w-80 border border-gray-700 bg-gray-500 py-2 text-white max-sm:left-0 md:right-1 md:top-10'

}>

{Array(4)

.fill('List Item')

.map((item, i) => (

<SortItem

isActive={i === 2}

title={item}

/>

))}

</div>

)}

{isOpen && (

<div

className={

'border-1 absolute top-28 z-30 w-80 border border-gray-700 bg-gray-500 py-2 text-white max-sm:left-0 md:right-1 md:top-10'

}>

{Array(4)

.fill('List Item')

.map((item, i) => (

<SortItem

isActive={i === 2}

title={item}

/>

))}

</div>

)}

Suggested change

{isOpen && (

<div

className={

'border-1 absolute top-28 z-30 w-80 border border-gray-700 bg-gray-500 py-2 text-white max-sm:left-0 md:right-1 md:top-10'

}>

{Array(4)

.fill('List Item')

.map((item, i) => (

<SortItem

isActive={i === 2}

title={item}

/>

))}

</div>

)}

{isOpen ? (

<div

className={

'border-1 absolute top-28 z-30 w-80 border border-gray-700 bg-gray-500 py-2 text-white max-sm:left-0 md:right-1 md:top-10'

}>

{Array(4)

.fill('List Item')

.map((item, i) => (

<SortItem

isActive={i === 2}

title={item}

/>

))}

</div>

) : null}

Majorfi · 2024-11-20T13:02:11Z

apps/common/components/SortingBar.tsx

+						.fill('List Item')
+						.map((item, i) => (
+							<SortItem
+								isActive={i === 2}


Missing key

Majorfi · 2024-11-20T13:04:01Z

pages/apps/[category].tsx

+				</div>
+
+				<div className={'flex grid-rows-1 flex-col gap-4 md:grid md:grid-cols-2 lg:grid-cols-4'}>
+					{shuffledApps?.map(app => <AppCard app={app} />)}


Missing key

Majorfi · 2024-11-20T13:04:33Z

pages/apps/search/[query].tsx

+					<p
+						className={cl(
+							'hidden truncate text-[64px] font-bold leading-[84px] text-white md:block',
+							searchFilteredApps.length < 1 ? 'mb-4' : 'mb-10'
+						)}>{`Results for "${searchValue}"`}</p>


Suggested change

<p

className={cl(

'hidden truncate text-[64px] font-bold leading-[84px] text-white md:block',

searchFilteredApps.length < 1 ? 'mb-4' : 'mb-10'

)}>{`Results for "${searchValue}"`}</p>

<p

className={cl(

'hidden truncate text-[64px] font-bold leading-[84px] text-white md:block',

searchFilteredApps.length < 1 ? 'mb-4' : 'mb-10'

)}>

{`Results for "${searchValue}"`}

</p>

Majorfi

Stuff not resolved

w84april requested review from Majorfi and Karlen9 November 20, 2024 11:11

vercel bot deployed to Preview November 20, 2024 11:12 View deployment

fix: home logo & footer

87a482c

vercel bot deployed to Preview November 20, 2024 12:15 View deployment

fix: logos

5bbd7bc

vercel bot deployed to Preview November 20, 2024 12:31 View deployment

w84april marked this pull request as ready for review November 20, 2024 12:44

Majorfi requested changes Nov 20, 2024

View reviewed changes

chore: layout fixes

2dfa07e

vercel bot deployed to Preview November 20, 2024 13:41 View deployment

fix: arrows scroll

98eda0e

vercel bot deployed to Preview November 20, 2024 13:49 View deployment

w84april added 3 commits November 20, 2024 16:58

fix: tailwind config

e267c17

fix: copies

ca0dea7

chore: resolve comments

74dba88

vercel bot deployed to Preview November 20, 2024 14:25 View deployment

Majorfi requested changes Nov 20, 2024

View reviewed changes

Majorfi merged commit 19a7805 into main Nov 20, 2024
9 checks passed

Majorfi deleted the feat/landing-merge branch November 20, 2024 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new yearn landing (#571) #608

feat: new yearn landing (#571) #608

w84april commented Nov 20, 2024

vercel bot commented Nov 20, 2024 •

edited

Loading

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

w84april Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi Nov 20, 2024

Majorfi left a comment

		{'your assets, andYearn puts them to work within the DeFi ecosystem, returning the earned'}
		{'yield back to you.'}

feat: new yearn landing (#571) #608

feat: new yearn landing (#571) #608

Conversation

w84april commented Nov 20, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

vercel bot commented Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Majorfi left a comment

Choose a reason for hiding this comment

vercel bot commented Nov 20, 2024 •

edited

Loading