fix: role allowed

yearn · Feb 6, 2024 · 83419aa · 83419aa
1 parent ee26e1a
commit 83419aa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contracts/debtAllocators/YieldManager/YieldManager.sol b/contracts/debtAllocators/YieldManager/YieldManager.sol
@@ -219,7 +219,7 @@ contract YieldManager is Governance {
      */
     function validateAllocation(
         address _vault,
-        Allocation[] memory _newAllocations
+        Allocation[] calldata _newAllocations
     ) external view virtual returns (bool) {
         // Get the total assets the vault has.
         uint256 _totalAssets = IVault(_vault).totalAssets();
@@ -253,7 +253,7 @@ contract YieldManager is Governance {
      */
     function getCurrentAndExpectedRate(
         address _vault,
-        Allocation[] memory _newAllocations
+        Allocation[] calldata _newAllocations
     )
         external
         view
@@ -319,7 +319,7 @@ contract YieldManager is Governance {
      */
     function updateAllocationPermissioned(
         address _vault,
-        Allocation[] memory _newAllocations
+        Allocation[] calldata _newAllocations
     ) external virtual onlyGovernance {
         address allocator = vaultAllocator[_vault];
         require(allocator != address(0), "vault not added");

diff --git a/tests/manager/test_role_manager.py b/tests/manager/test_role_manager.py
@@ -1511,7 +1511,7 @@ def test_remove_role(
             [strategy], daddy, ROLES.ADD_STRATEGY_MANAGER, sender=daddy
         )
 
-    with ape.reverts("!allowed"):
+    with ape.reverts("!governance"):
         role_manager.removeRoles(
             [vault], daddy, ROLES.ADD_STRATEGY_MANAGER, sender=user
         )