Query multiple tables using one entity #94
Conversation
There was a problem hiding this comment.
Mostly LGTM, this PR needs a little bit of polishing... and explicit @ExperimentalApi annotations to deter users who don't know the trade-offs of this implementation.
Please also add a basic test of the new functionality to YdbRepositoryIntegrationTest. To run the integration test, start YDB-in-Docker by running repository-ydb-v2/src/test/script/run-ydb.sh.
repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/YdbRepositoryTransaction.java
Show resolved
Hide resolved
...2/src/main/java/tech/ydb/yoj/repository/ydb/compatibility/YdbSchemaCompatibilityChecker.java
Show resolved
Hide resolved
repository/src/main/java/tech/ydb/yoj/repository/db/EntityDescriptor.java
Outdated
Show resolved
Hide resolved
| private static final AtomicBoolean useOldStatementFactory = new AtomicBoolean(Boolean.getBoolean("yoj.use.type.statement.factory")); | ||
|
|
||
| @Deprecated(forRemoval = true) | ||
| public static void setUseOldStatementFactory(boolean value) { |
There was a problem hiding this comment.
A comment for @lavrukov:
If you don't use custom table names, the YqlStatementFactory.Descriptor statement factory should produce the same YqlStatements as previous versions of YOJ.
But out of abundance of caution, we added a way to construct YqlStatements only using entity class, not (entity class [+ optional table name]). To use this legacy YqlStatementFactory implementation, set a Java property yoj.use.type.statement.factory to true or explicitly call YdbTable.setUseOldStatementFactory(true) before using YOJ.
repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/table/YdbTable.java
Show resolved
Hide resolved
repository/src/main/java/tech/ydb/yoj/repository/db/AbstractDelegatingTable.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/tech/ydb/yoj/repository/db/EntityDescriptor.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/tech/ydb/yoj/repository/db/EntityDescriptor.java
Outdated
Show resolved
Hide resolved
g-sg-v
force-pushed
the
query-multiple-tables
branch
from
0d20b93
to
4941b71
Compare
repository-ydb-v2/src/main/java/tech/ydb/yoj/repository/ydb/table/BatchFindSpliterator.java
Outdated
Show resolved
Hide resolved
repository/src/main/java/tech/ydb/yoj/repository/db/EntityDescriptor.java
Outdated
Show resolved
Hide resolved
No description provided.