fix(UserSettings): fix highlight on search #972
Conversation
artemmufazalov
commented
Jul 2, 2024
•
artemmufazalov
commented
| <Settings.Item key={setting.title} {...setting}> | ||
| {setting.content} | ||
| </Settings.Item> | ||
| ); | ||
| } | ||
| return <Setting key={setting.settingKey} {...setting} />; | ||
| return ( | ||
| <Settings.Item key={setting.title} {...setting}> | ||
| <Setting {...setting} /> | ||
| </Settings.Item> | ||
| ); |
There was a problem hiding this comment.
Previously, there was I problem, that if Settings.Item was not a direct child of Settings.Section, title was not rendered properly. To fix this, I mistakenly used highlightedTitle, so search didn't highlight anything
| @@ -31,7 +31,7 @@ const defaultUserSettings = settings; | |||
|
|
|||
| defaultUserSettings[2].sections[0].settings.push({ | |||
| title: i18n('settings.useClusterBalancerAsBackend.title'), | |||
| helpPopoverContent: i18n('settings.useClusterBalancerAsBackend.popover'), | |||
| description: i18n('settings.useClusterBalancerAsBackend.popover'), | |||
There was a problem hiding this comment.
Replaced helpPopoverContent with description and removed popovers, so all settings now will look similar (like Editor section)
There was a problem hiding this comment.
What do you think about move description to the right section? It's more place there.
There was a problem hiding this comment.
It looks good. However, I'd prefer to do it further, since it's not just an option in uikit component and requires some coding, and now we have quite enough space to display everything without scroll. Added issue to discuss it later: #974
artemmufazalov
force-pushed
the
settings-fix-highlight
branch
from
5b0da1a to
3348b27
Compare
| @@ -31,7 +31,7 @@ const defaultUserSettings = settings; | |||
|
|
|||
| defaultUserSettings[2].sections[0].settings.push({ | |||
| title: i18n('settings.useClusterBalancerAsBackend.title'), | |||
| helpPopoverContent: i18n('settings.useClusterBalancerAsBackend.popover'), | |||
| description: i18n('settings.useClusterBalancerAsBackend.popover'), | |||
There was a problem hiding this comment.
What do you think about move description to the right section? It's more place there.
artemmufazalov
force-pushed
the
settings-fix-highlight
branch
from
3348b27 to
7f38d6a
Compare
