fix(TenantNavigation): fix radio button value #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested changes
Jul 2, 2024
| return ( | ||
| <div className={b()}> | ||
| <RadioButton | ||
| width="auto" | ||
| onUpdate={handleUpdate} | ||
| size="l" | ||
| className={b('body')} | ||
| defaultValue={getCurrentItem().id} | ||
| value={tenantPage} |
There was a problem hiding this comment.
It seems that it will be enough just change property from defaultValue to value.
Lets stick to this and return all tabs calculations to useTenantNavigation?
There was a problem hiding this comment.
I don't understand, why we need to set current property to items and get current item with getCurrentItem, if we could just use tenantPage. For me it just adds complexity
There was a problem hiding this comment.
Decided to alter only value, to have all calculations separately from visualization
artemmufazalov
force-pushed
the
965-fix-tenant-tab
branch
from
6994c1f to
9791168
Compare
artemmufazalov
changed the title
Raubzeug
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #965