feat(Acl): improve view #955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
force-pushed
the
939-improve-acl
branch
from
0d29c46 to
5795cd9
Compare
artemmufazalov
requested changes
Jul 2, 2024
src/containers/Tenant/Acl/Acl.tsx
Outdated
Comment on lines
78
to
80
| if (!value) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
src/containers/Tenant/Acl/Acl.tsx
Outdated
Comment on lines
78
to
80
| if (!value) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
How it should look like for the user with default rights? Just Subject?
artemmufazalov
previously approved these changes
Jul 2, 2024
artemmufazalov
previously approved these changes
Jul 2, 2024
artemmufazalov
previously approved these changes
Jul 3, 2024
artemmufazalov
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #939