fix: fix incorrect truncate strings with popover #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
krosy1337
commented
Oct 23, 2023
krosy1337
commented
krosy1337
force-pushed
the
use-cell-with-popover
branch
from
5dc0e41 to
8745086
Compare
krosy1337
changed the title
krosy1337
force-pushed
the
use-cell-with-popover
branch
3 times, most recently
from
eb62001 to
a73f1da
Compare
krosy1337
force-pushed
the
use-cell-with-popover
branch
from
a73f1da to
a51eea3
Compare
artemmufazalov
requested changes
Oct 23, 2023
Comment on lines
20
to
24
| <div className={b('wrapper', wrapperClassName)}> | ||
| <Popover className={b(null, className)} {...props}> | ||
| {children} | ||
| </Popover> | ||
| </div> |
There was a problem hiding this comment.
It better to put b-style higher. So you have block__element inside block. It will be more correct in terms of BEM methodology. More specific styles should be further in components tree
artemmufazalov
approved these changes
Oct 23, 2023
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.