Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add loader for healthcheck #563

Merged
merged 2 commits into from
Oct 19, 2023
Merged

fix: add loader for healthcheck #563

merged 2 commits into from
Oct 19, 2023

Conversation

krosy1337
Copy link
Contributor

No description provided.

@krosy1337 krosy1337 marked this pull request as ready for review October 18, 2023 20:11

const renderContent = () => {
if (error) {
return <ResponseError error={error} defaultMessage={i18n('no-data')} />;
}

if (loading && !wasLoaded) {
return <Loader className={b('details-loader')} size="m" />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use Loader from src/components/Loader. It's a wrapped uikit Loader that is styled properly (so your added styles may be not needed)

artemmufazalov
artemmufazalov previously approved these changes Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants