Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tablet): redesign tablet page, add data from hive #1183

Merged
merged 6 commits into from
Aug 19, 2024
Merged

Conversation

Raubzeug
Copy link
Contributor

@Raubzeug Raubzeug commented Aug 19, 2024

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
114 112 0 2 0

Bundle Size: 🔺

Current: 79.00 MB | Main: 78.90 MB
Diff: +0.10 MB (0.12%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@Raubzeug Raubzeug linked an issue Aug 19, 2024 that may be closed by this pull request
border-bottom: 1px solid var(--g-color-line-generic);
}
&__table-cell {
height: 30px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataTable and PaginatedTable have row height 40px. This tab has table with 30px row height, it is noticeable, when switching tabs

src/components/InfoViewerSkeleton/InfoViewerSkeleton.tsx Outdated Show resolved Hide resolved
src/components/PDiskInfo/PDiskInfo.tsx Outdated Show resolved Hide resolved
src/services/api.ts Outdated Show resolved Hide resolved
src/containers/Tablet/Tablet.tsx Outdated Show resolved Hide resolved
src/containers/Tablet/Tablet.tsx Outdated Show resolved Hide resolved
@Raubzeug Raubzeug merged commit ab3528b into main Aug 19, 2024
6 checks passed
@Raubzeug Raubzeug deleted the 1042-tablet branch August 19, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve tablet page
2 participants