feat: search in queries history & saved #1127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Search is performed by query text field, case insensitive. Same behaviour on saved query tab |
Raubzeug
requested changes
Aug 7, 2024
|
|
||
| const queriesHistory = useTypedSelector(selectQueriesHistory); | ||
| const queriesHistory = useTypedSelector(selectQueriesHistory(filter)); |
There was a problem hiding this comment.
What do you think if we operate with filter in store? This allows to preserve filter value when tabs are switching, and all staff with filtering would be done inside redux selectors (it would be no need to pass filter there).
|
It seems that search should be case insensitive, cause sql keywords are both valid - uppercase and lowercase. |
Raubzeug
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔺
Current: 78.89 MB | Main: 78.89 MB
Diff: +0.01 MB (0.01%)
ℹ️ CI Information