Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop running query #1117

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

astandrik
Copy link
Collaborator

@astandrik astandrik commented Aug 5, 2024

Сloses #1062

Stand

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
62 59 0 3 0

Bundle Size: 🔺

Current: 78.88 MB | Main: 78.86 MB
Diff: +0.03 MB (0.04%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik force-pushed the astandrik.stop-running-query-1062-3 branch from 39d2575 to cb3df69 Compare August 5, 2024 10:55
@astandrik astandrik marked this pull request as ready for review August 5, 2024 11:59
@astandrik astandrik force-pushed the astandrik.stop-running-query-1062-3 branch 3 times, most recently from 4f91bed to aff8f4b Compare August 6, 2024 09:57
@astandrik astandrik requested a review from ValeraS August 6, 2024 15:39
Raubzeug
Raubzeug previously approved these changes Aug 7, 2024
await queryEditor.setQuery(invalidQuery);
await queryEditor.clickRunButton();

// Проверяем, что статус выполнения - "Failed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, write comments in English, we are open-source

@artemmufazalov
Copy link
Member

Looks like help with query settings is redundant for running query

Screenshot 2024-08-07 at 12 41 29

artemmufazalov
artemmufazalov previously approved these changes Aug 7, 2024
ValeraS
ValeraS previously approved these changes Aug 7, 2024
@astandrik astandrik dismissed stale reviews from ValeraS and artemmufazalov via 794334e August 7, 2024 11:32
@astandrik astandrik requested a review from ValeraS August 7, 2024 11:43
@astandrik astandrik merged commit a30258f into main Aug 7, 2024
6 checks passed
@astandrik astandrik deleted the astandrik.stop-running-query-1062-3 branch August 7, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants