fix(QueryHistory): query history not saving #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
previously approved these changes
Aug 2, 2024
|
added keybinding tests |
astandrik
force-pushed
the
astandrik.fix-query-history
branch
from
fe9d4d9
to
32de0f3
Compare
artemmufazalov
previously approved these changes
Aug 2, 2024
|
had a great time struggling to emulate keybindings for all platforms (: |
artemmufazalov
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like saving queries to history is broken
because handleExecute recieves react event as argument
made calling these functions explicit
added tests
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: ✅
Current: 78.85 MB | Main: 78.85 MB
Diff: +0.24 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information