feat: check whoami before other requests #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
force-pushed
the
935-whoami
branch
2 times, most recently
from
2763e83
to
a92e94c
Compare
artemmufazalov
commented
Aug 1, 2024
| @@ -78,7 +78,7 @@ export class YdbEmbeddedAPI extends AxiosWrapper { | |||
| // authUrl - external auth service link, after successful auth additional cookies will be appended | |||
| // that will allow access to clusters where OIDC proxy is a balancer | |||
| if (response && response.status === 401 && response.data?.authUrl) { | |||
| return window.location.assign(response.data.authUrl); | |||
| window.location.assign(response.data.authUrl); | |||
There was a problem hiding this comment.
window.location.assign doesn't happen immediately, return error so some normal error will be shown in between
artemmufazalov
force-pushed
the
935-whoami
branch
from
a92e94c
to
2b91ed4
Compare
ValeraS
requested changes
Aug 2, 2024
artemmufazalov
force-pushed
the
935-whoami
branch
from
2b91ed4
to
bffffc1
Compare
ValeraS
previously approved these changes
Aug 2, 2024
ValeraS
previously approved these changes
Aug 2, 2024
artemmufazalov
force-pushed
the
935-whoami
branch
from
5f1b9e9
to
6f86611
Compare
artemmufazalov
force-pushed
the
935-whoami
branch
2 times, most recently
from
ea2dcce
to
551812d
Compare
|
I will fix flaky tenants test in a separate PR. It seems, since page content is now loaded only after |
ValeraS
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #935
Stand: https://nda.ya.ru/t/6x0jcgOt77KX7s
CI Results
Test Status: ✅ PASSED
📊 Full Report
Bundle Size: 🔽
Current: 78.85 MB | Main: 78.91 MB
Diff: 0.05 MB (-0.07%)
✅ Bundle size decreased.
ℹ️ CI Information