feat(VDiskPage): add force evict #1093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemmufazalov
commented
Jul 30, 2024
| if (response?.result === false) { | ||
| const err = { | ||
| statusText: response.error, | ||
| retryPossible: response.forceRetryPossible && !isRetry, |
There was a problem hiding this comment.
Limit retries to 1
There was a problem hiding this comment.
Lets not add this limitation. Let backend to decide is eviction possible or not.
Raubzeug
requested changes
Jul 31, 2024
| if (response?.result === false) { | ||
| const err = { | ||
| statusText: response.error, | ||
| retryPossible: response.forceRetryPossible && !isRetry, |
There was a problem hiding this comment.
Lets not add this limitation. Let backend to decide is eviction possible or not.
artemmufazalov
force-pushed
the
1034-vdisk-force-evict
branch
from
67884f1
to
09847cc
Compare
Raubzeug
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1034
Stand: https://nda.ya.ru/t/35VXVc8K77Gygx
How to check: