fix: proper dispatch action

ydb-platform · Aug 16, 2024 · 0b1ad4d · 0b1ad4d
1 parent d936243
commit 0b1ad4d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx b/src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx
@@ -16,7 +16,6 @@ import {
     goToPreviousQuery,
     saveQueryToHistory,
     setTenantPath,
-    updateQueryInHistory,
 } from '../../../../store/reducers/executeQuery';
 import {explainQueryApi} from '../../../../store/reducers/explainQuery/explainQuery';
 import type {PreparedExplainResponse} from '../../../../store/reducers/explainQuery/types';
@@ -85,7 +84,6 @@ interface QueryEditorProps {
     showPreview: boolean;
     setShowPreview: (...args: Parameters<typeof setShowPreview>) => void;
     saveQueryToHistory: (...args: Parameters<typeof saveQueryToHistory>) => void;
-    updateQueryInHistory: (...args: Parameters<typeof updateQueryInHistory>) => void;
 }
 
 function QueryEditor(props: QueryEditorProps) {
@@ -172,10 +170,6 @@ function QueryEditor(props: QueryEditorProps) {
             schema,
             enableTracingLevel,
             queryId,
-        }).then((res) => {
-            if ('data' in res) {
-                props.updateQueryInHistory(res.data.stats, queryId);
-            }
         });
         setIsResultLoaded(true);
         props.setShowPreview(false);
@@ -419,7 +413,6 @@ const mapStateToProps = (state: RootState) => {
 
 const mapDispatchToProps = {
     saveQueryToHistory,
-    updateQueryInHistory,
     goToPreviousQuery,
     goToNextQuery,
     setShowPreview,

diff --git a/src/store/reducers/executeQuery.ts b/src/store/reducers/executeQuery.ts
@@ -195,7 +195,7 @@ export const executeQueryApi = api.injectEndpoints({
                     enableTracingLevel,
                     queryId,
                 },
-                {signal},
+                {signal, dispatch},
             ) => {
                 let action: ExecuteActions = 'execute';
                 let syntax: QuerySyntax = QUERY_SYNTAX.yql;
@@ -234,6 +234,8 @@ export const executeQueryApi = api.injectEndpoints({
                     }
 
                     const data = parseQueryAPIExecuteResponse(response);
+
+                    dispatch(updateQueryInHistory(data.stats, queryId));
                     return {data};
                 } catch (error) {
                     return {error};
@@ -251,12 +253,12 @@ export const saveQueryToHistory = (queryText: string, queryId: string) => {
     } as const;
 };
 
-export const updateQueryInHistory = (stats: IQueryResult['stats'], queryId: string) => {
+export function updateQueryInHistory(stats: IQueryResult['stats'], queryId: string) {
     return {
         type: UPDATE_QUERY_IN_HISTORY,
         data: {queryId, stats},
     } as const;
-};
+}
 
 export const goToPreviousQuery = () => {
     return {