Issue 50/remove snappy from contrib #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Пишет, что билд не получился. Починишь? |
Починил! |
GitSparTV
reviewed
Mar 22, 2024
contrib/libs/CMakeLists.txt
Outdated
| @@ -8,6 +8,6 @@ add_subdirectory(libc_compat) | |||
| add_subdirectory(lz4) | |||
| add_subdirectory(lzmasdk) | |||
| add_subdirectory(nayuki_md5) | |||
| add_subdirectory(snappy) | |||
| #add_subdirectory(snappy) | |||
There was a problem hiding this comment.
Кажется, правильней удалить строчку, чем комментировать
Gazizonoki
reviewed
Mar 22, 2024
cmake/external_libs.cmake
Outdated
| @@ -9,6 +9,7 @@ find_package(RapidJSON REQUIRED) | |||
| find_package(ZLIB REQUIRED) | |||
| find_package(xxHash REQUIRED) | |||
| find_package(ZSTD REQUIRED) | |||
| find_package(Snappy 1.1.10 REQUIRED CONFIG) | |||
There was a problem hiding this comment.
А почему 1.1.10? Так ли прям она нам нужна? Может поставить 1.1.8, и тогда пользователи смогут пользоваться apt, а не руками устанавливать либу?
There was a problem hiding this comment.
Да, я погорячился. Последние патчи в snappy в основном перформанс и сборку улучшали, и нет особых причин держаться за 1.1.10. Исправил
1.1.10 is too strict requirement, for which there's no necessary reason
Now we ask users to install snappy through apt package
Gazizonoki
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNAPPY_HAVE_X86_CRC32определяется, если архитектура поддерживает SSE4.2, но по факту на AMD и Intel SSE4.2 появился раньше, чем AVX, и на всех последующих микроархитектурах есть и то, и то, так что если есть поддержка SSE4.2, то всё равно подключится нужный хедер для AVX.