MOSIP-25073:Added the code fix for bugs in sonar analysis of admin-se…

…rvices
yashmsonkusare · Mar 12, 2024 · 11435cc · 11435cc
1 parent b7cba9a
commit 11435cc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/admin/admin-service/src/main/java/io/mosip/admin/packetstatusupdater/util/RestClient.java b/admin/admin-service/src/main/java/io/mosip/admin/packetstatusupdater/util/RestClient.java
@@ -204,7 +204,8 @@ public <T> T getApi(String url,
 		try {
 			ResponseEntity responseEntity= (ResponseEntity) restTemplate
 					.exchange(url, HttpMethod.GET, setRequestHeader(null, null), responseType);
-			if(url.contains("datashare") && responseEntity.getHeaders().getContentType().equals(MediaType.APPLICATION_JSON)){
+			MediaType contentType = responseEntity.getHeaders().getContentType();
+			if(url.contains("datashare") && contentType == null || contentType.equals(MediaType.APPLICATION_JSON)){
 				throw new MasterDataServiceException(ApplicantDetailErrorCode.DATA_SHARE_EXPIRED_EXCEPTION.getErrorCode(),
 						ApplicantDetailErrorCode.DATA_SHARE_EXPIRED_EXCEPTION.getErrorMessage());
 			}

diff --git a/...n/admin-service/src/main/java/io/mosip/admin/service/impl/ApplicantDetailServiceImpl.java b/...n/admin-service/src/main/java/io/mosip/admin/service/impl/ApplicantDetailServiceImpl.java
@@ -110,12 +110,16 @@ public ApplicantDetailsDto getApplicantDetails(String rid) throws Exception {
             JSONObject mapperIdentity=utility.getJSONObject(idenitityJsonObject,IDENTITY);
             List<String> mapperJsonKeys = new ArrayList<>(mapperIdentity.keySet());
             for(String valueObj: applicantDetails){
-                if(valueObj!=null && !valueObj.equalsIgnoreCase(ApplicantPhoto)){
-                    LinkedHashMap<String, String> jsonObject = utility.getJSONValue(mapperIdentity, valueObj);
-                    String value = jsonObject.get(VALUE);
-                    applicantDataMap.put(value,identityObj.get(value).toString());
-                } else if (valueObj.equalsIgnoreCase(ApplicantPhoto)) {
-                    getImageData(documents,applicantDataMap);
+                if(valueObj!=null) {
+                    if (!valueObj.equalsIgnoreCase(ApplicantPhoto)) {
+                        LinkedHashMap<String, String> jsonObject = utility.getJSONValue(mapperIdentity, valueObj);
+                        String value = jsonObject.get(VALUE);
+                        applicantDataMap.put(value, identityObj.get(value).toString());
+                    } else if (valueObj.equalsIgnoreCase(ApplicantPhoto)) {
+                        getImageData(documents, applicantDataMap);
+                    }
+                } else {
+                    throw new NullPointerException("valueObj is null");
                 }
             }
             saveApplicantLoginDetails();