macOS arm64 build #8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,3 +39,38 @@ jobs: | |
| with: | ||
| name: node${{ matrix.target-node }}-macos-x64 | ||
| path: dist/* | ||
|
|
||
| macos-arm64: | ||
| runs-on: macos-11.0 | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| target-node: [14, 16, 18, 19] | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: maxim-lobanov/setup-xcode@v1 | ||
| with: | ||
| xcode-version: latest | ||
|
|
||
| - name: Use Node.js 14 | ||
| uses: actions/setup-node@v1 | ||
| with: | ||
| node-version: 14 | ||
|
|
||
| - run: yarn install --ignore-engines | ||
|
|
||
| - run: yarn start --node-range node${{ matrix.target-node }} --arch arm64 --output dist | ||
|
There was a problem hiding this comment. How does this work? Is it actually compiling the node binary? There was a problem hiding this comment. Yeah that's what the scripts in this package do. As far as I remember. There was a problem hiding this comment. Is that script coming from the https://github.com/actions/setup-node/tree/main/src. I'm not super familiar with GitHub Actions, where can I find the source for what the actual script is? There was a problem hiding this comment. e.g. https://github.com/yao-pkg/pkg-fetch/blob/main/lib/build.ts, with the actual entry point defined in package.json. This entire repo is essentially a script/package to build and fetch patched node binaries suitable for pkg. |
||
|
|
||
| - name: Check if binary is compiled | ||
| id: check_file | ||
| run: | | ||
| (test -f dist/*.sha256sum && echo ::set-output name=EXISTS::true) || echo ::set-output name=EXISTS::false | ||
|
|
||
| - uses: actions/upload-artifact@v2 | ||
| if: steps.check_file.outputs.EXISTS == 'true' | ||
| with: | ||
| name: node${{ matrix.target-node }}-macos-arm64 | ||
| path: dist/* | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use matrix.target-node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's only the node version that is used for running the build script and doesn't matter as long as its new enough to run it. No need to vary it per target-node.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least use 18/20 as it's the currently lts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Probably should update this for all the jobs.