fix: update to node 18.18.2 and node 16.20.2

[n0cloud]

will need to update expected-shas.json, but I don't remember how to do that.

[robertsLando]

@n0cloud Thanks for your PR! Sorry for the delay but I missed it at start, the expected sha must be updated by me once I create a new patch release so don't worry about them :)

[robertsLando]

@n0cloud Could you try to run pkg-fetch locally using -t flag?

Check https://github.com/yao-pkg/pkg-fetch/blob/main/DEVELOPMENT.md for more info

Also not sure but maybe latest node 18 is 18.18.2 now?

[n0cloud]

node:assert:399
    throw err;
    ^

AssertionError [ERR_ASSERTION]: 108
    at [eval]:45:5
    at Script.runInThisContext (node:vm:125:12)
    at Object.runInThisContext (node:vm:301:38)
    at node:internal/process/execution:82:21
    at [eval]-wrapper:6:24
    at runScript (node:internal/process/execution:81:62)
    at evalScript (node:internal/process/execution:103:10)
    at node:internal/main/eval_string:29:3 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Node.js v18.18.2

I'm getting this error when I test, but v19 also throw this error.

[robertsLando]

@baparham any clue where that error comes from?

[robertsLando]

@n0cloud The verify script runs this code: https://github.com/yao-pkg/pkg-fetch/blob/main/lib/verify.ts#L6-L94

I think one of those assertions throws, could you edit it manually to see which one?

[n0cloud]

Th test script check for process.versions.modules version, but didn't have the version for 16, 18 and 19.

My latest commit should fix it

[robertsLando]

Thanks @n0cloud! If you confirm me that running pkg-fetch with -t option works I will merge this 🎉

[n0cloud]

➜  pkg-fetch git:(update-node-versions) yarn start -t --node-range node16                     
yarn run v1.22.19
$ node lib-es5/bin.js -t --node-range node16
> /home/gabriel/.pkg-cache/v3.5/built-v16.20.2-linux-x64
ok
Done in 0.23s.
➜  pkg-fetch git:(update-node-versions) yarn start -t --node-range node18
yarn run v1.22.19
$ node lib-es5/bin.js -t --node-range node18
> /home/gabriel/.pkg-cache/v3.5/built-v18.18.2-linux-x64
ok
Done in 0.21s.
➜  pkg-fetch git:(update-node-versions) yarn start -t --node-range node19
yarn run v1.22.19
$ node lib-es5/bin.js -t --node-range node19
> /home/gabriel/.pkg-cache/v3.5/fetched-v19.8.1-linux-x64
ok
Done in 0.40s.

I confirm

[robertsLando]

Let's see how this goes: https://github.com/yao-pkg/pkg-fetch/actions/runs/6536202980

[robertsLando]

@n0cloud Are you someway able to create node 20 patches?

[robertsLando]

PKG 5.9.2 published https://github.com/yao-pkg/pkg/releases/tag/v5.9.2 🎉