Resolves #26 Added HibernateQueryOnRequestResetInterceptor #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r which can be used to reset query detection state on each request
|
Tried first with using request scope for HibernateQueryInterceptor instead of ThreadLocal but this caused issued with direct repository access in my test setup. |
| @@ -57,6 +57,11 @@ | |||
| <artifactId>spring-boot-configuration-processor</artifactId> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>org.springframework.boot</groupId> | |||
| <artifactId>spring-boot-starter-web</artifactId> | |||
There was a problem hiding this comment.
That's a big dependency that may break projects of other users.
@reitzmichnicht Do you have an opinion since you optimized the dependencies?
| @@ -46,7 +46,7 @@ public HibernateQueryInterceptor( | |||
| /** | |||
| * Reset the N+1 query detection state | |||
| */ | |||
| private void resetNPlusOneQueryDetectionState() { | |||
| public void resetNPlusOneQueryDetectionState() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26 Added HibernateQueryOnRequestResetInterceptor which can be used to reset query detection state on each request