Владимир Каткалов @katkalov #25
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| package ru.yandex.yamblz.ui.layouts; | ||
|
|
||
| import android.content.Context; | ||
| import android.util.AttributeSet; | ||
| import android.view.View; | ||
| import android.view.ViewGroup; | ||
|
|
||
| import java.util.ArrayList; | ||
|
|
||
| public class CustomLayout extends ViewGroup { | ||
| private ArrayList<View> mMatchParentChildren = new ArrayList<>(); | ||
|
|
||
| public CustomLayout(Context context) { | ||
| this(context, null, 0); | ||
| } | ||
|
|
||
| public CustomLayout(Context context, AttributeSet attrs) { | ||
| this(context, attrs, 0); | ||
| } | ||
|
|
||
| public CustomLayout(Context context, AttributeSet attrs, int defStyleAttr) { | ||
| super(context, attrs, defStyleAttr); | ||
| } | ||
|
|
||
| @Override | ||
| protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) { | ||
| int horizontalPadding = getPaddingLeft() + getPaddingRight(); | ||
| int verticalPadding = getPaddingTop() + getPaddingBottom(); | ||
| int totalWidth = 0; | ||
| int layoutWidth = MeasureSpec.getSize(widthMeasureSpec) - horizontalPadding; | ||
| //Высота лейаута по высоте максимального элемента | ||
| int maxHeight = MeasureSpec.getSize(heightMeasureSpec) - verticalPadding; | ||
| int changedHeightMeasureSpec = heightMeasureSpec; | ||
|
|
||
| //Родитель может вызвать onMeasure не единожды | ||
| mMatchParentChildren.clear(); | ||
|
|
||
|
|
||
| for (int i = 0; i < getChildCount(); ++i) { | ||
| View child = getChildAt(i); | ||
|
|
||
| if (child.getVisibility() == GONE) { | ||
|
There was a problem hiding this comment. неплохо бы проверять скрыта ли вьюха и в onLayout |
||
| continue; | ||
| } | ||
|
|
||
| switch (child.getLayoutParams().width) { | ||
| case LayoutParams.MATCH_PARENT: | ||
| mMatchParentChildren.add(child); | ||
| break; | ||
| case LayoutParams.WRAP_CONTENT: | ||
| default: | ||
| measureChild(child, widthMeasureSpec, heightMeasureSpec); | ||
| totalWidth += child.getMeasuredWidth(); | ||
| int measuredHeight = child.getMeasuredHeight(); | ||
| if (maxHeight < measuredHeight) { | ||
| maxHeight = measuredHeight; | ||
| changedHeightMeasureSpec = MeasureSpec.makeMeasureSpec(maxHeight, MeasureSpec.UNSPECIFIED); | ||
|
There was a problem hiding this comment. UNSPECIFIED по идее не подразумевает никаких ограничений There was a problem hiding this comment. Ну да, у меня и нет желания его ограничивать по высоте. There was a problem hiding this comment. Это я к тому, что раз ограничений нет и maxHeight ни на что не влияет, то можно его и не передавать There was a problem hiding this comment. смысл в том, что по maxHeight будет определена высота самого лейаута потом There was a problem hiding this comment. да, верно, значит мой коммент неактуален |
||
| } | ||
| } | ||
| } | ||
| //Если осталось место или оно не ограничено, почему бы не показать matchParent | ||
| boolean haveSpace = (totalWidth < layoutWidth) | ||
| || widthMeasureSpec == MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED); | ||
| //И у нас есть, чем его заполнять | ||
| if ((mMatchParentChildren.size() > 0) && haveSpace) { | ||
| //В случае, если не знаем ширина родителя не остановленна,используем вдвое увеличенную ширину не match_parent элементов | ||
| layoutWidth = layoutWidth != 0 ? layoutWidth : totalWidth * 2; | ||
|
There was a problem hiding this comment. почему не утроенную ширину? There was a problem hiding this comment. Можно и утроенную) There was a problem hiding this comment. Да, три тоже хорошее число) мне кажется, если в сумме все потомки превышают ширину экрана, то ширина match_parent вьюхи, должна быть просто 0, так как места для нее нет. Так получается более предсказуемо, чем умножать на 2, 3 и любое другое число. There was a problem hiding this comment. =) There was a problem hiding this comment. ну да, теперь зачитаться можно) There was a problem hiding this comment. сорян) у меня фантазия разыгралась тогда) |
||
| //Остаток разделям между оставшимися детьми | ||
| int mpChildWidth = (layoutWidth - totalWidth) / mMatchParentChildren.size(); | ||
| int childWidthMeasureSpec = MeasureSpec.makeMeasureSpec(mpChildWidth, MeasureSpec.EXACTLY); | ||
| for (int i = 0; i < mMatchParentChildren.size(); i++) { | ||
| int childHeightMeasureSpec = getChildMeasureSpec( | ||
| heightMeasureSpec, | ||
| verticalPadding, | ||
| mMatchParentChildren.get(i).getLayoutParams().height | ||
| ); | ||
| mMatchParentChildren.get(i).measure( | ||
| childWidthMeasureSpec, | ||
| childHeightMeasureSpec | ||
| ); | ||
| totalWidth += mMatchParentChildren.get(i).getMeasuredWidth(); | ||
| int measuredHeight = mMatchParentChildren.get(i).getMeasuredHeight(); | ||
| if (maxHeight < measuredHeight) { | ||
| maxHeight = measuredHeight; | ||
| changedHeightMeasureSpec = MeasureSpec.makeMeasureSpec(maxHeight, MeasureSpec.AT_MOST); | ||
| } | ||
| } | ||
| } | ||
| super.onMeasure(MeasureSpec.makeMeasureSpec(layoutWidth + horizontalPadding, MeasureSpec.EXACTLY), changedHeightMeasureSpec); | ||
| } | ||
|
|
||
| @Override | ||
| protected void onLayout(boolean changed, int l, int t, int r, int b) { | ||
|
|
||
| int horizontalOffset = getPaddingLeft(); | ||
| int verticalOffset = getPaddingTop(); | ||
| int childCount = getChildCount(); | ||
| for (int i = 0; i < childCount; ++i) { | ||
| View child = getChildAt(i); | ||
| if (child.getVisibility() == GONE) { | ||
| continue; | ||
| } | ||
| int childWidth = child.getMeasuredWidth(); | ||
| int childHeight = child.getMeasuredHeight(); | ||
| child.layout(horizontalOffset, verticalOffset, horizontalOffset + childWidth, verticalOffset + childHeight); | ||
| horizontalOffset += childWidth; | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,24 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <ScrollView xmlns:android="http://schemas.android.com/apk/res/android" | ||
|
|
||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:orientation="vertical"> | ||
|
|
||
|
|
||
| <include layout="@layout/inner_test_1"/> | ||
| <include layout="@layout/inner_test_2"/> | ||
| <include layout="@layout/inner_test_3"/> | ||
| <include layout="@layout/inner_test_33"/> | ||
| <include layout="@layout/inner_test_5"/> | ||
| <include layout="@layout/inner_test_6"/> | ||
| <include layout="@layout/inner_test_7"/> | ||
| <include layout="@layout/inner_test_8"/> | ||
| <include layout="@layout/inner_test_9"/> | ||
| <include layout="@layout/inner_test_10"/> | ||
|
|
||
| </LinearLayout> | ||
| </ScrollView> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:orientation="vertical"> | ||
|
|
||
| <TextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="wrap_content LL and CL with expecly width for all" /> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="100dp"> | ||
|
|
||
| <TextView | ||
| android:layout_width="10dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/gray" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="100dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorAccent" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="50dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimary" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="70dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimaryDark" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="1000dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/d2m_font_default_description" /> | ||
|
|
||
| </LinearLayout> | ||
|
|
||
|
|
||
| <TextView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="1dp" | ||
| android:background="@color/black" /> | ||
|
|
||
| <ru.yandex.yamblz.ui.layouts.CustomLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="100dp"> | ||
|
|
||
| <TextView | ||
| android:layout_width="10dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/gray" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="100dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorAccent" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="50dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimary" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="70dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimaryDark" /> | ||
|
|
||
|
|
||
| <TextView | ||
| android:layout_width="1000dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/d2m_font_default_description" /> | ||
|
|
||
| </ru.yandex.yamblz.ui.layouts.CustomLayout> | ||
|
|
||
| <TextView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="3dp" | ||
| android:background="@color/black" /> | ||
| </LinearLayout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:orientation="vertical"> | ||
|
|
||
| <TextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="LL and CL with child margin" | ||
| /> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="match_parent" | ||
| android:layout_height="100dp" | ||
| > | ||
|
|
||
| <TextView | ||
| android:layout_width="10dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/gray" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="100dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorAccent" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="0dp" | ||
| android:layout_weight="1" | ||
| android:layout_margin="8dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimary" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="70dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimaryDark" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="50dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/d2m_font_default_description" /> | ||
|
|
||
| </LinearLayout> | ||
|
|
||
|
|
||
| <TextView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="1dp" | ||
| android:background="@color/black" /> | ||
|
|
||
| <ru.yandex.yamblz.ui.layouts.CustomLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="100dp"> | ||
|
|
||
| <TextView | ||
| android:layout_width="10dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/gray" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="100dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorAccent" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:layout_margin="8dp" | ||
| android:background="@color/colorPrimary" /> | ||
|
|
||
| <TextView | ||
| android:layout_width="70dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/colorPrimaryDark" /> | ||
|
|
||
|
|
||
| <TextView | ||
| android:layout_width="50dp" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/d2m_font_default_description" /> | ||
|
|
||
| </ru.yandex.yamblz.ui.layouts.CustomLayout> | ||
|
|
||
| <TextView | ||
| android:layout_width="match_parent" | ||
| android:layout_height="3dp" | ||
| android:background="@color/black" /> | ||
| </LinearLayout> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нужно учитывать паддинги и при измерении
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
согласен, мой косяк
просто сравнив с linear'ом получил одинаковый результат(на скриншоте первом видно), и не стал задумываться
видимо тест не очень удачный
при первой возможности пофикшу
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
потыкал паддинги в методе измерения
ни к чему хорошему это не приводит)
наверно потому, что за меня это решает метод измерения суперкласса
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А можешь показать, где это супер класс делает?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Отказать, первое предположение было неверно
Осознал
Я вызываю для детей measureChild и он там вызывает getChildMeasureSpec и он думает, что я передаю родительские MeasureSpec поэтому хватает падинги родителя и смело из с их учетом расчитывает чилда.
И если это так и происходит для первых детей, то для детей которые match_parent это не так.
Это все будет работать до тех пор, пока match_parent в лейауте один. :)
то есть по сути задание выполнено)))
но надо бы исправить, чтобы для двух
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Так view.measure не учитывает паддинги, паддинги учитывает measureChild, поэтому просто измерится по ширине и высоте родительской вьюхи без каких либо ограничений, а при отрисовке паддинг учитывается.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
да я про прошлый случай и рассказывал, про measureChild. Типа почему это все работало раньше :)
Пока тыкался сейчас, понял, что забыл проверять отсутствие match_parent элементов и делил на 0. Видимо, забыл добавить проверку, когда решил, что у меня может быть их больше одного. so sad
пофиксил
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
разобрались) в общем, это просто тонкий момент, который нужно в голове держать
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
понял. спасибо, было познавательно)
как-нибудь на досуге буду разбираться еще с мерджинами потомков, чтобы совсем проникнуться)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
без проблем