Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community Addon -> YCom #25

Merged
merged 4 commits into from
Nov 6, 2017
Merged

Community Addon -> YCom #25

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b567ad7
Community Addon -> YCom
TobiasKrais Nov 6, 2017
6e7f883
Methodenersetzung abgesichert
TobiasKrais Nov 6, 2017
6db8c28
Verwendung Klassenname abgesichert
TobiasKrais Nov 6, 2017
b1059a4
Community rename failsafe
TobiasKrais Nov 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/YConverter/Converter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,13 @@ public function boot()
['seo42\s*::\s*getLangCode\((.*?)\)' => 'rex_clang::getCurrent()->getCode()'],
['seo42\s*::\s*getBaseUrl\((.*?)\)' => 'rex::getServer()'],
]
], [
// Community Addon -> YCom
'replaces' => [
['checkperm' => 'checkPerm'],
['community' => 'ycom'],
['rex_com_auth' => 'rex_ycom_auth'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke für den PR. Wenn das Methoden oder Funktionen sind, wäre es gut das die Regex genauer wäre. Ansonsten passiert es, dass community auch im Fließtext mit ycom ersetzt wird.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checkperm ist eine Methode.
  • community lediglich der Addon Name. Die Ersetzung finde ich auch potentiell riskant.
  • rex_com_auth ist der Klassenname.

]
],
];

Expand Down