Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove attributes with value "null" #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xong
Copy link

@xong xong commented Feb 4, 2021

This allows to explicitly remove attributes, e. g. the controls attribute.

@tbaddade
Copy link
Member

tbaddade commented Feb 4, 2021

Verstehe nicht. Wenn, dann gehört die Änderung m.E. in rex_string::buildAttributes. Aber man verliert dann Attribute dieser Art <video controls></video>. Und das ist sicherlich nicht gewollt.

@xong
Copy link
Author

xong commented Feb 4, 2021

Es geht genau darum, dass das controls-Attribut nicht ausgegeben werden darf. Wenn ich bei buildAttributes ein Attribut nicht benötige, übergebe ich es einfach nicht.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants