Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding metadata tag to non rendered tags #142

Merged

Conversation

ldevillez
Copy link
Collaborator

Description

Metadata is a valid svg tag but it should not be directly rendered.

Fixes #141

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested with the svg from #141. The tikz output is similar to the svg.

Checklist:

  • My code follows the style guidelines of this project (black/pylint)
  • I have updated the changelog with the corresponding changes
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ldevillez ldevillez linked an issue Sep 29, 2023 that may be closed by this pull request
@ldevillez ldevillez merged commit dc4f272 into master Sep 29, 2023
4 checks passed
@bchardin
Copy link

Thanks for the fix. The test from #141 now also works for me.

@ldevillez ldevillez deleted the 141-nodes-sometimes-dont-have-the-is_visible-attribute branch November 17, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nodes sometimes don't have the is_visible attribute
2 participants