Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH340G Usb-to-Serial support (Arduino-based clones) #1

Closed
wants to merge 2 commits into from

Conversation

DRSDavidSoft
Copy link

@DRSDavidSoft DRSDavidSoft commented Feb 7, 2018

Hey @xxxajk, since there seems to be more active development in this fork, I'd like to merge @ideniden's modifications to Physicaloid which makes it support CH340G USB-to-Serial chips. These chips are used in a lot of Arduino-based clones.

That way, when your pull-request merges into the main branch (hopefully soon), we'd already have CH340G support.

Of course, @ideniden's code seems to need a bit of refactoring, so if you've got some time on hand, merging and cleaning those are much appreciated.

Thanks for your time!

@DRSDavidSoft
Copy link
Author

My apologies, but there seems to be a problem with @ideniden's implementation:

java.lang.NullPointerException: Attempt to invoke virtual method 'int android.hardware.usb.UsbDeviceConnection.controlTransfer(int, int, int, int, byte[], int, int)' on a null object reference
    at com.physicaloid.lib.usb.driver.uart.UartCH340.setBaudrate(UartCH340.java:151)
    at com.physicaloid.lib.usb.driver.uart.UartCH340.setUartConfig(UartCH340.java:106)
    at com.physicaloid.lib.framework.Uploader.upload(Uploader.java:47)
    at com.physicaloid.lib.Physicaloid$1.run(Physicaloid.java:417)

I'm sorry for opening this pull request, it needs to be delayed until this problem is sorted out.

@xxxajk
Copy link
Owner

xxxajk commented Feb 7, 2018

That would be extremely cool. Can you resolve the conflicts?

@xxxajk
Copy link
Owner

xxxajk commented Feb 7, 2018

Also, please note that I do not use any of the gradle stuff, so I don't maintain any of it.
I use Apache ant for building on classic android setup.
So if there is anything that needs to be changed/added there to add in the new stuff I put in, I'm ignorant if it has any adverse effects.

@xxxajk
Copy link
Owner

xxxajk commented Aug 3, 2018

Broken, besides I have written my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants