Media connector test implemented. #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
approved these changes
Aug 14, 2020
kidunot89
force-pushed
the
tests/media-connector
branch
from
0afda5b
to
0c28b64
Compare
kidunot89
commented
Aug 27, 2020
| @@ -151,7 +151,7 @@ public function callback_add_attachment( $post_id ) { | |||
| $url = $post->guid; | |||
| $parent_id = $post->post_parent; | |||
| $parent = get_post( $parent_id ); | |||
| $parent_title = $parent_id ? $parent->post_title : null; | |||
| $parent_title = $parent instanceof \WP_Post ? $parent->post_title : 'Unidentifiable post'; | |||
kidunot89
force-pushed
the
tests/media-connector
branch
from
19f3fc2
to
3e9e674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1093
Fixes #907
Summary Checklist
add_attachmentcallback test implemented and passing. Refactored to avoid breaking on invalid parent posts.delete_attachmentcallback test implemented and passing.edit_attachmentcallback test implemented and passing.wp_save_image_editor_filecallback test implemented and passing.wp_save_image_filecallback because the hook is deprecated in WordPress andwp_save_image_editor_fileis the replacement.#907 patch implemented here to avoid future merge conflicts if put in separate PR.