Users connector class test implemented. #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidunot89
changed the title
kidunot89
added
the
needs discussion
kidunot89
added
the
work in progress
kidunot89
force-pushed
the
tests/users-connector
branch
from
1273fca
to
41f23f6
Compare
kidunot89
changed the title
kidunot89
removed
needs discussion
dero
requested changes
Sep 16, 2020
There was a problem hiding this comment.
@kidunot89 This looks really good, just a couple comments here. Thanks!
classes/class-connector.php
Outdated
| @@ -91,10 +91,6 @@ public function register() { | |||
| * Unregister all context hooks | |||
| */ | |||
| public function unregister() { | |||
| if ( ! $this->is_registered ) { | |||
There was a problem hiding this comment.
@kidunot89 Can you give me more context for this change? Why is it being removed?
There was a problem hiding this comment.
@dero Because I noticed that somewhere between tests the connectors where ending in a state where the callback hooks were registered and the is_registered flag was false but the action were still registered and somehow prevent the mocked connector class actions from getting the data on logs catching deletions. This has actually been happening across multiple connector test and is also the cause for hold up on the last test of the comment connector test case
kidunot89
force-pushed
the
tests/users-connector
branch
from
fd6f11a
to
9f97ac6
Compare
kidunot89
force-pushed
the
tests/users-connector
branch
from
9f97ac6
to
f940b94
Compare
kidunot89
force-pushed
the
tests/users-connector
branch
from
f940b94
to
8c35864
Compare
kidunot89
force-pushed
the
tests/users-connector
branch
from
8c35864
to
4fa2253
Compare
kidunot89
force-pushed
the
tests/users-connector
branch
from
4fa2253
to
96d03b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #1093
Potentially fixes #946
Summary checklist
clear_auth_cookiecallback test implemented and passing.delete_usercallback test implemented and passing.deleted_usercallback test implemented and passing.password_resetcallback test implemented and passing.profile_updatecallback test implemented and passing.retrieve_passwordcallback test implemented and passing.set_current_usercallback test implemented and passing.set_logged_in_cookiecallback test implemented and passing.set_user_rolecallback test implemented and passing.user_registercallback test implemented and passing.