Fix: Remove old records #1076
Closed
Fix: Remove old records #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this is a cron-job
kasparsd
commented
Mar 25, 2020
| if ( | ||
| is_multisite() | ||
| && | ||
| is_network_admin() |
There was a problem hiding this comment.
I'm not sure why is_network_admin() would need to be checked on cron runs.
kasparsd
commented
Mar 25, 2020
| $current_page = wp_stream_filter_input( INPUT_GET, 'action' ); | ||
| } | ||
|
|
||
| if ( 'wp_stream_network_settings' === $current_page ) { |
There was a problem hiding this comment.
Use the network settings if the plugin is network-activated. Is there a situation we would like to use network settings when the plugin is not network activated?
|
It has been a while since last looked into this and it would be great if we could fix the actual issue without changing so much of the surrounding code. I'm going to close this for now and we should create a new pull request just for the bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056.
Checklist
contributing.md).