fix: result list should not be equatable

xsoulspace · May 17, 2021 · c3964b6 · c3964b6
1 parent 8197453
commit c3964b6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/dart_packages/cactus_sync_client_gen/lib/src/gql_model_builder.dart b/dart_packages/cactus_sync_client_gen/lib/src/gql_model_builder.dart
@@ -112,7 +112,7 @@ class GqlModelBuilder extends GqlObjectTypeDefinition {
     final Set<Parameter> defaultConstructorInitializers = {};
     // FIXME: Issue #2
     String itemsBaseTypeName = '';
-    for (final field in typeDefinition.fields) {
+    void fillField(gql_schema.FieldDefinition field) {
       final args = field.args;
       if (args != null && args.isNotEmpty == true) {
         fillClassMethodField(
@@ -139,6 +139,10 @@ class GqlModelBuilder extends GqlObjectTypeDefinition {
         );
       }
     }
+
+    for (final field in typeDefinition.fields) {
+      fillField(field);
+    }
     if (serializable) {
       fillSerializers(
         definedMethods: definedMethods,

diff --git a/dart_packages/cactus_sync_client_gen/lib/src/gql_object_type_definition.dart b/dart_packages/cactus_sync_client_gen/lib/src/gql_object_type_definition.dart
@@ -56,7 +56,7 @@ class GqlObjectTypeDefinition {
           ],
         ),
     );
-    final getters = isEquatable
+    final getters = isEquatable && !isResultList
         ? [
             Method(
               (m) => m
-Original file line number
+Diff line change
@@ Expand Up / @@ -56,7 +56,7 @@ class GqlObjectTypeDefinition { @@
               ],
             ),
         );
-        final getters = isEquatable
+        final getters = isEquatable && !isResultList
             ? [
                 Method(
                   (m) => m
@@ Expand Down @@