Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Jekyll theme #5

Closed
wants to merge 12 commits into from
Closed

Convert to Jekyll theme #5

wants to merge 12 commits into from

Conversation

guillermocalvo
Copy link

@guillermocalvo guillermocalvo commented May 21, 2017

I refactored the theme so that it can be used with Jekyll.
This makes it really easy using the theme in GitHub Pages.

LIVE DEMO

I would like to create a new branch gh-pages into this repository, but GitHub cannot create a pull request with a target branch that does not exist yet. Therefore I used master branch. Please feel free to modify this pull request if you want.

Resolves #1.

@Frotty
Copy link

Frotty commented Jun 19, 2017

Hey, this is pretty awesome @guillermocalvo
It seems like the repository owner isn't active anymore, so I have but one request for you:

The theme is nice and working, but I find it rather sad that there are no anchors for headings in a doc-page.
This means you cannot send someone a link of a specific position inside the page, which might be very big.
I think this is my only major concern - is there an easy way you could implement this to your fork?

Kind Regards.

@guillermocalvo
Copy link
Author

Hi @Frotty,

I don't exactly understand what kind of anchors are you missing there. The template currently generates anchors for all sections, and kramdown automatically generates IDs for all headings.

For example, you can try these links to the live demo:

Please let me know if those were the anchors you meant. If I got it all wrong, could you please provide me with an specific example of what you intend to achieve?

Regards.

@Frotty
Copy link

Frotty commented Jun 19, 2017

Hi, you are right, those are the anchors. I just noticed that you can rightclick the sidebar-links "copy link address" to get the anchor, but leftclick will not make it appear in the address bar of my browser (chrome).

I guess I would prefer it, if a leftclick also made the anchor appear.

Also, am I right that you didn't enable Prism?
I had to add it to doc.html before I was able to use it.

@guillermocalvo
Copy link
Author

Hey @Frotty, just made a small change to display anchors in the browser. Please check it out 👍

You are right about Prism, I disabled it because Jekyll has its own highlighter; I think it's better that way because the code is highlighted just once (server-side).

@Frotty
Copy link

Frotty commented Jun 20, 2017

Thanks for the patch 👍

Maybe add a note about Prism. I disabled the default rogue highlighter with highlighter: none in config.yml to keep my custom highlighter for Prism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting this to Jekyll theme
2 participants