-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to Jekyll theme #5
Conversation
Hey, this is pretty awesome @guillermocalvo The theme is nice and working, but I find it rather sad that there are no anchors for headings in a doc-page. Kind Regards. |
Hi @Frotty, I don't exactly understand what kind of anchors are you missing there. The template currently generates anchors for all sections, and kramdown automatically generates IDs for all headings. For example, you can try these links to the live demo:
Please let me know if those were the anchors you meant. If I got it all wrong, could you please provide me with an specific example of what you intend to achieve? Regards. |
Hi, you are right, those are the anchors. I just noticed that you can rightclick the sidebar-links "copy link address" to get the anchor, but leftclick will not make it appear in the address bar of my browser (chrome). I guess I would prefer it, if a leftclick also made the anchor appear. Also, am I right that you didn't enable Prism? |
Hey @Frotty, just made a small change to display anchors in the browser. Please check it out 👍 You are right about Prism, I disabled it because Jekyll has its own highlighter; I think it's better that way because the code is highlighted just once (server-side). |
Thanks for the patch 👍 Maybe add a note about Prism. I disabled the default rogue highlighter with |
I refactored the theme so that it can be used with Jekyll.
This makes it really easy using the theme in GitHub Pages.
I would like to create a new branch
gh-pages
into this repository, but GitHub cannot create a pull request with a target branch that does not exist yet. Therefore I usedmaster
branch. Please feel free to modify this pull request if you want.Resolves #1.