Skip to content
This repository has been archived by the owner on Sep 2, 2022. It is now read-only.

implement literal handling in compiler and engine #69

Merged
merged 6 commits into from
Oct 30, 2020
Merged

implement literal handling in compiler and engine #69

merged 6 commits into from
Oct 30, 2020

Conversation

tsatke
Copy link
Contributor

@tsatke tsatke commented Oct 28, 2020 •
edited
Loading

@tsatke tsatke requested a review from SUMUKHA-PK as a code owner October 28, 2020 14:25
SUMUKHA-PK
SUMUKHA-PK reviewed Oct 29, 2020
View reviewed changes
internal/compiler/numeric_parser.go Show resolved Hide resolved
internal/engine/numeric_parser_test.go Show resolved Hide resolved
internal/engine/projected_table.go Outdated Show resolved Hide resolved
internal/engine/projected_table_iterator.go Show resolved Hide resolved
internal/engine/projected_table_iterator.go Show resolved Hide resolved
internal/engine/selection.go Show resolved Hide resolved
internal/engine/selection.go Show resolved Hide resolved
internal/engine/table/string.go Show resolved Hide resolved
@tsatke tsatke changed the title #55 #57 #58 implement literal handling in compiler and engine implement literal handling in compiler and engine Oct 29, 2020
SUMUKHA-PK
SUMUKHA-PK approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@SUMUKHA-PK SUMUKHA-PK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsatke tsatke merged commit 9f7c385 into master Oct 30, 2020
@tsatke tsatke deleted the literal-handling branch October 30, 2020 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SUMUKHA-PK SUMUKHA-PK SUMUKHA-PK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsatke @SUMUKHA-PK