Skip to content
This repository has been archived by the owner on Apr 5, 2020. It is now read-only.

Commit

Permalink
Only set internal_encoding for iconv with PHP < 5.6
Browse files Browse the repository at this point in the history
Doing so has been deprecated and replaced by the setting "default_charset",
see https://wiki.php.net/rfc/default_encoding. Since its default value is
UTF-8 (which == xp::ENCODING), we do not have to do anything for PHP 5.6+
  • Loading branch information
thekid committed Jan 7, 2016
1 parent 00b91ea commit c3b9088
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion shared/src/class-main.php
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@

// Start I/O layers
$encoding= get_cfg_var('encoding');
iconv_set_encoding('internal_encoding', \xp::ENCODING);
PHP_VERSION < '5.6' && iconv_set_encoding('internal_encoding', \xp::ENCODING);
array_shift($_SERVER['argv']);
array_shift($argv);
if ($encoding) {
Expand Down

0 comments on commit c3b9088

Please sign in to comment.