missing nullable dispose

xorus · Feb 9, 2022 · cdd1816 · cdd1816
1 parent ebf822e
commit cdd1816
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/PluginCommandManager.cs b/PluginCommandManager.cs
@@ -80,6 +80,7 @@ private void RemoveCommandHandlers()
 
         public void Dispose()
         {
+            GC.SuppressFinalize(this);
             RemoveCommandHandlers();
         }
     }

diff --git a/PluginUi.cs b/PluginUi.cs
@@ -44,6 +44,7 @@ public void OpenSettings()
 
         public void Dispose()
         {
+            GC.SuppressFinalize(this);
             _stopwatch?.Dispose();
             _dtrBarUi?.Dispose();
         }

diff --git a/Ui/DtrBarUi.cs b/Ui/DtrBarUi.cs
@@ -52,7 +52,8 @@ public void Update()
 
         public void Dispose()
         {
-            _entry.Dispose();
+            GC.SuppressFinalize(this);
+            _entry?.Dispose();
         }
     }
 }
diff --git a/Ui/FloatingWindow.cs b/Ui/FloatingWindow.cs
@@ -208,6 +208,7 @@ private void BuildFont()
 
         public void Dispose()
         {
+            GC.SuppressFinalize(this);
             _pluginInterface.UiBuilder.BuildFonts -= BuildFont;
             _pluginInterface.UiBuilder.RebuildFonts();
             // _font.Destroy(); - crashes when I do this
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,6 +80,7 @@ private void RemoveCommandHandlers() @@
             public void Dispose()
             {
+                GC.SuppressFinalize(this);
                 RemoveCommandHandlers();
             }
         }
@@ Expand Down @@