fs, File and Path API #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_file_access_layer_111
radumarias
requested changes
Dec 15, 2024
| async_util::call_async(crate::crypto::fs_api::r#async::fs::metadata(self)) | ||
| } | ||
|
|
||
| pub fn symlink_metadata(&self) -> Result<Metadata> { |
There was a problem hiding this comment.
add rustdoc to indicate it's not implemented
| Ok(stack.iter().collect::<PathBuf>()) | ||
| } | ||
|
|
||
| pub fn read_link(&self) -> Result<PathBuf> { |
There was a problem hiding this comment.
We don't yet have links implemented and we need to ask links from EncryptedFs, not local path like std Path does, so make this unimplemented and add rustdoc too
| Ok(PathBuf::from(path.read_link())) | ||
| } | ||
|
|
||
| pub fn read_dir(&self) -> Result<ReadDir> { |
There was a problem hiding this comment.
You need to interrogate EncryptedFs, not std Path :) we have that method in there
| #[cfg(test)] | ||
| mod test; | ||
|
|
||
| /// Wrapper around [`std::path::Path`] to allow use on EncryptedFs. |
There was a problem hiding this comment.
Is this accurate? as we don't use std Path internally, maybe use similar term?
radumarias
requested changes
Dec 16, 2024
| @@ -57,7 +53,7 @@ async fn init_fs() -> anyhow::Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn _add_create<'a>(opts: &'a mut OpenOptions, path: &Path) -> &'a mut OpenOptions { | |||
| fn _add_create<'a>(opts: &'a mut OpenOptions, path: &std::path::Path) -> &'a mut OpenOptions { | |||
| if !path.to_path_buf().exists() { | |||
There was a problem hiding this comment.
I think here we need to use crypto::fs_api::path::Path
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #97
Implementation for:
crypto::fs_api::async::fs::OpenOptions
crypto::fs_api::async::fs::File (partial)
crypto::fs_api::async::fs (partial)
crypto::fs_api::path::Path.
crypto::fs_api::path::PathBuf.
Still on the to do list: