Abstract file access layer #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radumarias
requested changes
Sep 19, 2024
src/crypto/cryptofs.rs
Outdated
| /// ``` | ||
| #[allow(dead_code)] | ||
| pub struct CryptoOptions<'a, State> { | ||
| state: State, |
There was a problem hiding this comment.
call these as in the Rust API, like OpenOptions
There was a problem hiding this comment.
These are fixed. Plus removed some dead fields in the state structs.
Will work on more docs and tests soon.
src/crypto/cryptofs.rs
Outdated
|
|
||
| #[derive(Debug)] | ||
| pub struct File { | ||
| pub fh: u64, |
src/crypto/cryptofs/test.rs
Outdated
| @@ -0,0 +1,167 @@ | |||
| use std::str::FromStr; | |||
There was a problem hiding this comment.
Module is now called tests.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for issue 111.
Will add more docs and tests before merge.