enable xopt init from yaml file #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikitakuklev I think we should require formatting using ufmt so we don't go back and forth on this and that is the formatting we have used in the past. Is this ok? (sorry to add the pain) |
|
As long as we are consistent, its ok. You will convert to the holy path of ruff eventually :) Should a pre-commit hook be added to enforce it? |
|
sure, do you know how to add? |
|
ufmt page has both CI action and pre-commit examples - up to you which one to add (maybe CI is easier since flake is already checked) |
ChristopherMayes
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #150
restores black formatting