Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agones Game Server Client SDK #376

Closed

Conversation

aallbrig
Copy link

@aallbrig aallbrig commented Jun 11, 2024

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/AgonesSDK
  • Add a link to the dependency NuGet package: https://www.nuget.org/packages/Google.Api.CommonProtos
  • Add a link to the dependency NuGet package: https://www.nuget.org/packages/Grpc
  • It must have non-preview versions: 1.41.0 (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@aallbrig
Copy link
Author

Issue this will fix: #375

@aallbrig
Copy link
Author

@bdovaz I'm looking forward to making this contribution to open source and would appreciate your guidance. Thanks for the opportunity! Please review this PR when you can.

@aallbrig
Copy link
Author

Need to take a look at why the build failed.

…ependencies' dependencies are already satisfied)
@aallbrig
Copy link
Author

aallbrig commented Jun 11, 2024

Added in AgonesSDK dependencies (Google.Api.CommonProtos, Grpc) as well. Updated top comment to include nuget package URLs there too.

The build is ready to be re-ran.

@aallbrig aallbrig closed this Jun 20, 2024
@aallbrig
Copy link
Author

Closing this PR; made post on associated "issue" to explain why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant