Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GraphQL.Client 1.0.0 #368

Merged
merged 8 commits into from
Jun 19, 2024
Merged

Added GraphQL.Client 1.0.0 #368

merged 8 commits into from
Jun 19, 2024

Conversation

IvanMurzak
Copy link
Contributor

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/GraphQL.Client
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@IvanMurzak IvanMurzak changed the title Added GraphQL.Client 2.0.0 Added GraphQL.Client 1.0.0 May 31, 2024
@IvanMurzak
Copy link
Contributor Author

The package `GraphQL.Client.Serializer.Newtonsoft.3.1.8` has a dependency on `Panic.StringUtils` which is not in the registry. You must add this dependency to the registry.json file.

That is the only one version 3.1.8 across all other versions that has the dependency on Panic.StringUtils. Can we ignore the GraphQL.Client.Serializer.Newtonsoft.3.1.8 but still include rest of versions? I would love to include Panic.StringUtils but it doesn't support .netstandard2.0 or 2.1.

@bdovaz
Copy link
Collaborator

bdovaz commented Jun 1, 2024

Change the version to 3.1.9 and add an exception here with the reason:

var excludedPackages = new string[] {

@bdovaz bdovaz merged commit 82fb148 into xoofx:master Jun 19, 2024
2 checks passed
@IvanMurzak IvanMurzak deleted the GraphQL-2.0.0 branch June 19, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants