Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry.json #351

Closed
wants to merge 1 commit into from
Closed

Conversation

MonoLogueChi
Copy link
Contributor

add zlogger and zstring

zlogger https://www.nuget.org/packages/ZLogger
Utf8StringInterpolation https://www.nuget.org/packages/Utf8StringInterpolation/
zstring https://www.nuget.org/packages/ZString/

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/XXX
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

add zlogger and zstring
@bdovaz
Copy link
Collaborator

bdovaz commented Apr 2, 2024

@MonoLogueChi why did you close it? For compatibility? Just curious in case someone wants to use this package.

@MonoLogueChi
Copy link
Contributor Author

@MonoLogueChi why did you close it? For compatibility? Just curious in case someone wants to use this package.

Because I don't know if I should modify this PR. Utf8StringInterpolation, which supports the minimum version of .NET Standard 2.0, depends on PolySharp, which is not a .NET Standard 2.0 package. The latest version of Utf8StringInterpolation removes this dependency, but does not meet the requirements for supporting the minimum version of .NET Standard 2.0.

@MonoLogueChi
Copy link
Contributor Author

@MonoLogueChi why did you close it? For compatibility? Just curious in case someone wants to use this package.

I've been modifying my logging module recently and want to try using Zlogger instead of the logs I used to assemble manually. Maybe others will have the same use.

@MonoLogueChi
Copy link
Contributor Author

Can UnityNuGet ignore non-existent dependencies? If so, I can resubmit the PR after solving other problems.

@bdovaz
Copy link
Collaborator

bdovaz commented Apr 3, 2024

  1. Add "Utf8StringInterpolation" with "1.3.1" because as you say it is the first version that does not depend on "PolySharp".
  2. Add "ZLogger" with "2.0.1" which is the first one that depends on "Utf8StringInterpolation" >= 1.3.1.
  3. Add exclusions of those 2 with a comment why so you don't get test failures:
    var excludedPackages = new string[] {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants