Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift packages with too many versions #332

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Lift packages with too many versions #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions registry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,15 @@
},
"AWSSDK.Core": {
"listed": true,
"version": "3.3.100"
"version": "3.7.302.8"
},
"AWSSDK.S3": {
"listed": true,
"version": "3.3.100"
"version": "3.7.302.8"
},
"AWSSDK.SecurityToken": {
"listed": true,
"version": "3.3.100"
"version": "3.7.302.8"
},
"Ben.Demystifier": {
"listed": true,
Expand Down Expand Up @@ -314,7 +314,7 @@
},
"CSharpFunctionalExtensions": {
"listed": true,
"version": "1.8.1"
"version": "2.40.3"
},
"CsvHelper": {
"listed": true,
Expand Down Expand Up @@ -405,7 +405,7 @@
},
"Google.Apis.AndroidPublisher.v3": {
"listed": true,
"version": "1.35.1.1312"
"version": "1.66.0.3324"
},
"Google.Apis.Auth": {
"listed": true,
Expand Down Expand Up @@ -1475,15 +1475,15 @@
},
"UnitsNet": {
"listed": true,
"version": "4.0.0"
"version": "5.28.0"
},
"UnitsNet.NumberExtensions": {
"listed": true,
"version": "4.44.0"
"version": "5.28.0"
},
"UnitsNet.Serialization.JsonNet": {
"listed": true,
"version": "4.0.0"
"version": "5.28.0"
},
"Validation": {
"listed": true,
Expand Down
13 changes: 9 additions & 4 deletions src/UnityNuGet.Tests/RegistryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,12 @@ public async Task Ensure_Min_Version_Is_Correct_Ignoring_Analyzers_And_Native_Li

var excludedPackages = new string[] {
// All versions target "Any" and not .netstandard2.0 / 2.1
@"AWSSDK.S3",
// All versions target "Any" and not .netstandard2.0 / 2.1
@"AWSSDK.SecurityToken",
// It has too many versions, the minimum version is lifted so as not to process so many versions
@"AWSSDK.*",
// It has too many versions, the minimum version is lifted so as not to process so many versions
@"CSharpFunctionalExtensions",
// It has too many versions, the minimum version is lifted so as not to process so many versions
@"Google.Apis.AndroidPublisher.v3",
// Versions prior to 1.11.24 depend on System.Xml.XPath.XmlDocument which does not target .netstandard2.0
@"HtmlAgilityPack",
// Although 2.x targets .netstandard2.0 it has an abandoned dependency (Remotion.Linq) that does not target .netstandard2.0.
Expand All @@ -129,7 +132,9 @@ public async Task Ensure_Min_Version_Is_Correct_Ignoring_Analyzers_And_Native_Li
// Versions < 4.6.0 in theory supports .netstandard2.0 but it doesn't have a lib folder with assemblies and it makes it fail.
@"System.Private.ServiceModel",
// Versions < 0.8.6 depend on LiteGuard, a deprecated dependency.
@"Telnet"
@"Telnet",
// It has too many versions, the minimum version is lifted so as not to process so many versions
@"UnitsNet.*"
};

var excludedPackagesRegex = new Regex(@$"^{string.Join('|', excludedPackages)}$");
Expand Down