Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.ValueTuple-4.4.0 #321

Closed
wants to merge 1 commit into from

Conversation

IvanMurzak
Copy link
Contributor

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/XXX
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@bdovaz
Copy link
Collaborator

bdovaz commented Jan 25, 2024

This package is included with .NET Standard, you do not have to include it again:

https://github.com/xoofx/UnityNuGet/blob/master/src/UnityNuGet/DotNetHelper.cs

image

@IvanMurzak
Copy link
Contributor Author

Thank you. I will check compilation errors without it.

@bdovaz bdovaz closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants