Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added [email protected] #299

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Added [email protected] #299

merged 3 commits into from
Dec 28, 2023

Conversation

vrenken
Copy link
Contributor

@vrenken vrenken commented Dec 19, 2023

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/System.Threading.Tasks.Dataflow
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

  • Lowest version on nuget.org is 6.0.0.
  • Package is tested and used in EtAlii.UniCon (available on OpenUPM)
  • Package has no dependencies.

Sidenote: Great initiative - I finally have some time to create PR's for some of the packages we are still using as embedded assemblies.

@TapioRantala
Copy link
Contributor

From logs:

2023-12-19T23:31:03.7099819Z   Failed Ensure_Min_Version_Is_Correct_Ignoring_Analyzers_And_Native_Libs [1 s]
2023-12-19T23:31:03.7099902Z   Error Message:
2023-12-19T23:31:03.7100044Z      Package System.Threading.Tasks.Dataflow
2023-12-19T23:31:03.7100125Z   Expected: <4.8.0>
2023-12-19T23:31:03.7100202Z   But was:  <6.0.0>

@vrenken
Copy link
Contributor Author

vrenken commented Dec 21, 2023

Splendid how you configured Roslyn analyzers to spotting these....

@bdovaz bdovaz merged commit f6de6e6 into xoofx:master Dec 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants