Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OneOf Package #262

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Add OneOf Package #262

merged 2 commits into from
Nov 6, 2023

Conversation

GwendalBroudin-Emoko
Copy link
Contributor

Add OneOF package https://www.nuget.org/packages/OneOf/

Dependencies: None

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/XXX
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@GwendalBroudin-Emoko GwendalBroudin-Emoko changed the title Update registry.json Add OneOf Package Oct 19, 2023
@TapioRantala
Copy link
Contributor

2023-10-19T15:25:46.4974790Z   Failed Ensure_Min_Version_Is_Correct_Ignoring_Analyzers_And_Native_Libs [11 s]
2023-10-19T15:25:46.5035089Z   Error Message:
2023-10-19T15:25:46.5050086Z      Package OneOf
2023-10-19T15:25:46.5057619Z   Expected: <3.0.205>
2023-10-19T15:25:46.5058013Z   But was:  <3.0.263>

You need to set the version as 3.0.205 (as the oldest supporting netstandard2.0)

@GwendalBroudin-Emoko
Copy link
Contributor Author

Oh sorry, I didn't read the history correctly

@bdovaz bdovaz merged commit 2a6358c into xoofx:master Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants