Replace pipes.quote with shlex.quote on Python 3 #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shlex.quote() API is available from Python 3.3 on; pipes.quote() was never documented, and is removed in Python 3.13. Fixes xolox#73.
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 30, 2024
The test restriction is dropped as the test suite seems to work. It was necessary to apply patch [1] in order to make py3.13 work. [1] xolox/python-humanfriendly#75 Signed-off-by: Petr Vaněk <[email protected]>
smoser
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I'm not a maintainer, but I think this looks good.
Perhaps it fits in the 'compat.py'
This module exposes aliases and functions that make it easier to write Python
code that is compatible with Python 2 and Python 3.
and then used from there. But either way, it would be nice to have this as python 3.13 is eminent.
Thanks for the PR @musicinmybrain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shlex.quote()API is available from Python 3.3 on;pipes.quote()was never documented, and is removed in Python 3.13.Fixes #73.