Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade ruby version dependency
In commit d9b59ff,
required_ruby_version
was changed from 1.8.6 to 1.9.3. However, I was able to successfully build and run the specs (rake compile && rake test
) on ruby 1.8.7p358 (OSX 10.9.5).Likewise,
gem build libxslt-ruby.gemspec && gem install libxslt-ruby-1.1.1.gem
successfully installed the gem on ruby 1.8.7, although parsing documentation failed: rdoc/rdoc#327Update Rakefile
Additionally, the rake:rdoc task expects to find a README file. It instead needs to search for the README.rdoc file.